search

facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.19k stars 3k forks source link

Stop hijacking gflags.h (#9161) #9166

Closed Atry closed 2 years ago

Atry commented 2 years ago

Summary: We hijacked gflags/gflags.h to the folly/portability/GFlags.h to use DEFINE_xxx / DECLEAR_xxx provided by Folly. This approach does not work since https://github.com/facebook/folly/commit/4dadde1256f74e756510a499c86459967f78afb9, because Folly does not provide DEFINE_xxx / DECLEAR_xxx any more.

This PR removes the hijacking because it does not work any more.

Pull Request resolved: https://github.com/facebook/hhvm/pull/9161

Test Plan: Both internal CI and GitHub Action should pass

Differential Revision: D39078280

Pulled By: Atry

facebook-github-bot commented 2 years ago

This pull request was exported from Phabricator. Differential Revision: D39078280