search

facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.19k stars 3k forks source link

Add fbcode_builder to module path #9172

Closed Atry closed 2 years ago

Atry commented 2 years ago

Summary: This diff adds fbcode_builder to module path so that we could use find modules that are consistent with other OSS projects. This diff should not change the find_package behavior for now because HHVM's own find modules still have higher priority.

I will create more diff to remove some HHVM's own find modules to switch to fbcode_builder's find modules, especially find modules for glog and gflags.

The NO_MODULE option is added, because fbcode_builder provided a FindLibUnwind.cmake that is incompatible with existing find_package(LibUnwind) call.

Differential Revision: D39313365

facebook-github-bot commented 2 years ago

This pull request was exported from Phabricator. Differential Revision: D39313365