search

facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.19k stars 3k forks source link

Remove -DWITHOUT_GFLAGS=ON for thrift #9173

Closed Atry closed 2 years ago

Atry commented 2 years ago

Summary: We hijacked gflags/gflags.h to the folly/portability/GFlags.h to use DEFINE_xxx / DECLEAR_xxx provided by Folly. This approach does not work since https://github.com/facebook/folly/commit/4dadde1256f74e756510a499c86459967f78afb9, because Folly does not provide DEFINE_xxx / DECLEAR_xxx any more. Accordingly we patched fbthrift with without-gflags.patch to prevent it from linking gflags in favor of the hijacked gflags header.

This diff removes the without-gflags.patch so that fbthrift could decide whether linking to gflags via normal gflags detection logic.

Differential Revision: D39298863

facebook-github-bot commented 2 years ago

This pull request was exported from Phabricator. Differential Revision: D39298863