search

facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.19k stars 3k forks source link

Remove hphp's FindGlog.cmake #9174

Closed Atry closed 2 years ago

Atry commented 2 years ago

Summary: Since we have added fbcode_builder to HHVM's CMake module path in D39313365, now this diff switches FindGlog.cmake to the fbcode_builder version.

Note that HHVM's own FindGlog.cmake violates CMake's variable naming conversion. FindGlog.cmake should define variables with a GLOG_ prefix, not a LIBGLOG_ prefix. This diff switches the variables to GLOG_ prefix defined in fbcode_builder's FindGlog.cmake.

Differential Revision: D39284637

facebook-github-bot commented 2 years ago

This pull request was exported from Phabricator. Differential Revision: D39284637