Link with glog::glog - Githubissues

facebook / hhvm

A virtual machine for executing programs written in Hack.

https://hhvm.com

Other

18.19k stars 3k forks source link

Link with glog::glog #9175

Closed Atry closed 2 years ago

Atry commented 2 years ago

Summary: Since we have added the gflags as a dependency to glog::glog defined in fbcode_builder's FindGlog.cmake in D39220438 (https://github.com/facebook/hhvm/commit/55f2e7a1e0e279b72085a7e21c41a7ea7bba952e), and we have switched HHVM to use fbcode_builder's FindGlog.cmake in D39284637. Now this diff links both glog and its dependencies gflags by linking glog::glog.

Differential Revision: D39280796

facebook-github-bot commented 2 years ago

This pull request was exported from Phabricator. Differential Revision: D39280796