search

facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.19k stars 3k forks source link

fix race in range-for #9182

Open mrfox321 opened 2 years ago

mrfox321 commented 2 years ago

Summary: acquiring the lock of folly::Synchronized in a range-for will drop the lock. This is racy on the container / iterator.

Reviewed By: chadaustin

Differential Revision: D39397524

facebook-github-bot commented 2 years ago

This pull request was exported from Phabricator. Differential Revision: D39397524

facebook-github-bot commented 1 year ago

Hi @mrfox321!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!