search

facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.19k stars 3k forks source link

Build gen-rust.cpp in C++ mode #9185

Closed Atry closed 2 years ago

Atry commented 2 years ago

I encountered an error about 'cstdio' file not found when trying to build HHVM with CMake and Clang. See https://github.com/facebook/hhvm/actions/runs/3041342472/jobs/4898360446 It seems that build.rs tries to compile gen-rust.cpp as a C source file. This PR added .cpp(true) option so that gen-rust.cpp can be built as a C++ source file. Test Plan: Rebase #9129 onto this PR and the error 'cstdio' file not found should be gone.

facebook-github-bot commented 2 years ago

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

@Atry has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 2 years ago

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.