Closed Atry closed 2 years ago
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
mcrouter
is usingfolly/concurrency/AtomicSharedPtr.h
, which does not support Clang according the comment at https://github.com/facebook/hhvm/blob/156a77d5a301033200601ddefb4dcaf26eb1ff9c/third-party/folly/src/folly/concurrency/detail/AtomicSharedPtr-detail.h#L28-L34Test Plan:
Without this PR
Without this PR, mcrouter will fail:
With this PR
With this PR, there will be no error about mcrouter in the build log