search

facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.19k stars 3k forks source link

Remove libgccgit #9211

Closed Atry closed 2 years ago

Atry commented 2 years ago

Previously I added libgccgit to the HHVM nix package, in order to add /nix/store/ykgwb51j5235xdbkqnznm2haygknmwc6-libgccjit-11.3.0/lib/libatomic.so.1 to the library search path so that find_library could find libatomic.so.1's full path. However, it is unnecessary because gcc also provides another libatomic.so.1, which is always available by using the -latomic flag, even when libatomic.so.1 is not in the library search path.

This PR removes libgccgit and instead lets gcc directly link HHVM with gcc's built-in libatomic if find_library cannot find the full path of libatomic.so.1. This PR could avoid potential ABI incompatibility between gcc's and libgccgit's libatomic.so.1 .

Test Plan: Both internal CI and GitHub Actions for gcc should pass. The GitHub Action for clang is expected to fail because we have not fully port HHVM OSS to clang.

facebook-github-bot commented 2 years ago

@Atry has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 2 years ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

@Atry has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 2 years ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

@Atry has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 2 years ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

@Atry has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 2 years ago

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.