search

facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.19k stars 3k forks source link

Add -fsized-deallocation compile option #9218

Closed Atry closed 2 years ago

Atry commented 2 years ago

Fb-thrift uses C++17's operator delete, which requires -fsized-deallocation when building c++ source code with clang and libstdc++.

https://github.com/facebook/hhvm/blob/9832791642981d582d0f29c6d89dba2c879cc43d/third-party/thrift/src/thrift/lib/cpp/ContextStack.cpp#L229-L230

Test Plan: Rebase #9129 onto this PR, then there will be no error message about operator delete.

facebook-github-bot commented 2 years ago

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

@Atry has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 2 years ago

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

@Atry has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 2 years ago

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

This pull request was exported from Phabricator. Differential Revision: D39707592

facebook-github-bot commented 2 years ago

@Atry has updated the pull request. You must reimport the pull request before landing.