search

facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.19k stars 3k forks source link

Let HHVM nix package use system locale #9233

Closed Atry closed 2 years ago

Atry commented 2 years ago

glibc provided by nixpkgs does not use system locale by default according to https://nixos.org/manual/nixpkgs/unstable/#locales and https://nixos.wiki/wiki/Locales . The behavior would surprise users of universal deb packages.

This diff sets a fallback value for LOCALE_ARCHIVE environment variable so that glibc will locate the system locale by default.

This diff installs some locales in GitHub Actions, and the all suite of tests should be able to find them. As a result, less conditional tests should be skipped.

Test Plan:

hphp/test/slow/ext_hsl/locale.php and other conditional tests should not be skipped in GitHub Actions

facebook-github-bot commented 2 years ago

This pull request was exported from Phabricator. Differential Revision: D39910692

facebook-github-bot commented 2 years ago

This pull request was exported from Phabricator. Differential Revision: D39910692

facebook-github-bot commented 2 years ago

This pull request was exported from Phabricator. Differential Revision: D39910692

facebook-github-bot commented 2 years ago

This pull request was exported from Phabricator. Differential Revision: D39910692

facebook-github-bot commented 2 years ago

This pull request was exported from Phabricator. Differential Revision: D39910692

facebook-github-bot commented 2 years ago

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.