search

facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.19k stars 3k forks source link

Change default CMake build directory to _build #9248

Closed Atry closed 2 years ago

Atry commented 2 years ago

build directory is used by fbcode_builder in most Meta Platforms' open source project, therefore we should avoid the build directory for CMake generated files.

This PR let VS Code's CMake tool uses _build directory for CMake generated files.

Test Plan:

  1. Create a GitHub Codespace for this PR
  2. Open hhvm.code-workspace
  3. Click the Configure All Projects button from VS Code's CMake tool

The _build directory should include CMake generated files.

facebook-github-bot commented 2 years ago

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.