search

facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.19k stars 3k forks source link

Add BUILD_ALWAYS ON to first-party dependencies #9280

Closed Atry closed 2 years ago

Atry commented 2 years ago

According to the document, BUILD_ALWAYS ONBUILD_ALWAYS ON is recommended for external projects whose source code is not downloaded, otherwise the external projects will not be built when updating the source code.

Test Plan:

  1. Build HHVM in a GitHub Codespace for this Pull Request
  2. git pull to includes some other commits where some source files in first-party dependences are changed.
  3. Run make again

The changed source files should be rebuilt with the BUILD_ALWAYS ON option.

facebook-github-bot commented 2 years ago

@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.