Remove CMake checks for curl_multi_select/wait

facebook / hhvm

A virtual machine for executing programs written in Hack.

https://hhvm.com

Other

18.19k stars 3k forks source link

Closed jchaffraix-slack closed 1 year ago

jchaffraix-slack commented 2 years ago

libcURL has had curl_multi_wait since 7.28.0: https://curl.se/libcurl/c/curl_multi_wait.html

Note that I couldn't find a reference to curl_multi_select so I don't think cURL was ever released with it.

All OS should ship with a newer version at this point so we can remove those unneeded CMake checks.

Wilfred commented 1 year ago

Yeah, it looks like an internal patch until curl_multi_wait was available: 941abe0d6200d743cc1682fad179d601b9b2834c

facebook-github-bot commented 1 year ago

@Wilfred has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@Wilfred merged this pull request in facebook/hhvm@31f9f87e25f3dbf41c3ad064ecea83089a94bab9.