Remove unhandled STREAM_CRYPTO_METHOD_TLS*CLIENT

facebook / hhvm

A virtual machine for executing programs written in Hack.

https://hhvm.com

Other

18.19k stars 3k forks source link

Remove unhandled STREAM_CRYPTO_METHOD_TLS*CLIENT #9320

Closed jchaffraix-slack closed 1 year ago

jchaffraix-slack commented 1 year ago

Those constants come from PHP and they were never handled by HHVM, which would confuse users of the API. Also some of the old protocols should not be supported.

As Hack has evolved enough from PHP, this seems like a low compatibility risk. Furthermore, it signals the right expectations moving forward and we can always add those back if we add an implementation for those.

facebook-github-bot commented 1 year ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@Wilfred merged this pull request in facebook/hhvm@a5ce6b07f0327455206c1017c097d502381f2677.