Moving SR specific impls into ServiceInfo.cpp (#406)

facebook / hhvm

A virtual machine for executing programs written in Hack.

https://hhvm.com

Other

18.14k stars 2.99k forks source link

Moving SR specific impls into ServiceInfo.cpp (#406) #9339

Closed antonl2 closed 1 year ago

antonl2 commented 1 year ago

Summary: X-link: https://github.com/facebook/mcrouter/pull/406

This should improve compilation time for cpp files that include ServiceInfo.h The idea is to extract namespace level functions that do not depend on any template parameters and move its implementation to cpp file. Also removing mcrouter_sr_deps.h from RouteHandleTraverser.h as a related change

Differential Revision: D43330742

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D43330742

facebook-github-bot commented 1 year ago

This pull request has been merged in facebook/hhvm@0d2c3549d43aaf35985d8482d1ea03fbc3299581.