search

facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.14k stars 2.99k forks source link

Remove always passing check #9342

Closed jchaffraix-slack closed 1 year ago

jchaffraix-slack commented 1 year ago

third-party/CMakeLists.txt is in the main repository so the file will always be present and the branch will never be taken. The check didn't seem super useful, so I removed it rather than fixing it to point to one of the git submodules in HHVM.

facebook-github-bot commented 1 year ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@jchaffraix-slack has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 1 year ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@jchaffraix-slack has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 1 year ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

This pull request has been merged in facebook/hhvm@aa205b94ba5d363fe5854a659e13a612a2c00247.