search

facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.14k stars 2.99k forks source link

Use third-party/tbb to build HHVM #9344

Closed jchaffraix-slack closed 1 year ago

jchaffraix-slack commented 1 year ago

We currently don't use the TBB in third-party/tbb for building HHVM, which is causing some issues with the Ubuntu 22.04 update.

This PR updates our CMake files to use the TBB in third-party. This uses ExternalProject_add to build the existing code in a bundled target. This complemented with an interface target that exports the static library to the rest of HHVM.

The approach eschews TBB's CMake recommendation (a custom function called tbb_build) as this seemed poorly integrated and adds more opacity to our build. Instead we just call make directly to build the code.

This removes the need for calling find_package(tbb) so FindTBB.cmake was removed too.

facebook-github-bot commented 1 year ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@jchaffraix-slack has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 1 year ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@jchaffraix-slack has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 1 year ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@Wilfred merged this pull request in facebook/hhvm@192814737ffc839dce62f3bdecf0b3cfb7516285.