search

facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.19k stars 3k forks source link

Remove nix from github actions #9359

Closed fredemmott closed 1 year ago

fredemmott commented 1 year ago

This has been failing since February; we have passing Ubuntu builds on GitHub actions now.

One difference is that the nix build runs the quick hhvm tests, but Ubuntu doesn't; while we'd like to get the tests passing on Ubuntu, I'm not seeing it as a practical issue, given the nix failure is a build failure - it doesn't get to the tests.

facebook-github-bot commented 1 year ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

This pull request has been merged in facebook/hhvm@d3e0c18479763e826b685721d804b315c951d5aa.