search

facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.19k stars 3k forks source link

directory-structure.md: src/hhbc -> src/hackc #9383

Open SamB opened 1 year ago

SamB commented 1 year ago

The new byte-compiler got renamed in commit: 43f86984885592c6b2d55a7bdc9e242fab38efcf (Rename directory hhbc to hackc), presumably to disabiguate it from the bytecode format.

I'm not sure how to write tests for this file, but it would be nice if it had some.

facebook-github-bot commented 1 year ago

Hi @SamB!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!