facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.06k stars 2.99k forks source link

Fix Ubuntu CI #9391

Closed WangGithubUser closed 10 months ago

WangGithubUser commented 10 months ago

Not all exists command have a alternative, but if there is one, a soft link will in the /etc/alternatives. If you try to delete a alternative that not exists, will get this:update-alternatives: error: no alternatives for cc. This PR added a condition when deleting the alternative, and the error not raised: image

Footnote: The failing of step Installing HHVM deps and building HHVM is unrelated to this PR.

facebook-github-bot commented 10 months ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Wilfred commented 10 months ago

LGTM, thanks!

facebook-github-bot commented 10 months ago

This pull request has been merged in facebook/hhvm@247e3c330ec67ae20980e8b8a18369fd768a9a40.