Pass ASAN_OPTIONS to external-worker processes

facebook / hhvm

A virtual machine for executing programs written in Hack.

https://hhvm.com

Other

18.06k stars 2.99k forks source link

Pass ASAN_OPTIONS to external-worker processes #9394

Closed jchaffraix-slack closed 9 months ago

jchaffraix-slack commented 9 months ago

external-worker creates new processes using Folly::Subprocess, which relies on execve. This means that the new process does not automatically inherit any environment variables from the current process.

ASAN's behavior can be tweaked using ASAN_OPTIONS, which is important to prevent false positives (e.g. when running with leak tracking).

This PR solves compiling repo auth under some ASAN conditions:

$ hhvm --hphp -o repo_auth --input_dir=/path/to/codebase

facebook-github-bot commented 9 months ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 9 months ago

This pull request has been merged in facebook/hhvm@1df2a9d3aa96e95e204108a82ef023e7b4ac8c02.