search

facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.06k stars 2.99k forks source link

Attempt to fix duplicate flag issue #9400

Closed terrelln closed 8 months ago

terrelln commented 8 months ago

Summary: X-link: https://github.com/facebook/fbthrift/pull/579

CacheLib noticed OSS build failures due to JSONProtocolCommon.cpp being linked into the build twice, after we added a GFLAG to that file.

This diff attempts to fix the issue by depending on thriftprotocol rather than duplicating the files.

The code claims that it couldn't depend on thriftprotocol due to a circular dependency (added in D24720566), but Sandcastle and GitHub Actions is passing, so it doesn't seem to still be an issue.

Differential Revision: D50505357

facebook-github-bot commented 8 months ago

This pull request was exported from Phabricator. Differential Revision: D50505357

facebook-github-bot commented 8 months ago

This pull request was exported from Phabricator. Differential Revision: D50505357

facebook-github-bot commented 8 months ago

This pull request has been merged in facebook/hhvm@088a8c08b7194bc04f928ef006fd92b12730342f.

facebook-github-bot commented 8 months ago

This pull request has been reverted by 84aaadf9778fbe8abea07f9dddb8b178d7bebf21.