search

facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.2k stars 3k forks source link

Paramatized rust_static_library to enable CXX support #9403

Closed jdelliot closed 1 year ago

jdelliot commented 1 year ago

Summary: X-link: https://github.com/facebook/folly/pull/2092

X-link: https://github.com/facebook/fb303/pull/42

X-link: https://github.com/facebookincubator/velox/pull/7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, USE_CXX_INCLUDE, to the CMake function, rust_static_library, to enable adding the cxxbridge path to the include path.

Differential Revision: D50772544

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D50772544

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D50772544

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D50772544

facebook-github-bot commented 1 year ago

This pull request has been merged in facebook/hhvm@15b2460463fd5d7aaef1824ebbeab347545fb165.