search

facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.21k stars 3k forks source link

Option to set where the perf maps go #9404

Closed jchaffraix-slack closed 8 months ago

jchaffraix-slack commented 1 year ago

This matches other options like PerfJitDumpDir or CoreDumpReportDirectory.

For simplicity, this controls both the perf map and the perf id map.

facebook-github-bot commented 1 year ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 9 months ago

@jchaffraix-slack has updated the pull request. You must reimport the pull request before landing.

jchaffraix-slack commented 8 months ago

After spending more time on this code, we realized that only perf consumes the perf map and that this PR is actually not needed. Closing...