search

facebook / hhvm

A virtual machine for executing programs written in Hack.
https://hhvm.com
Other
18.06k stars 2.99k forks source link

Optimize multiple symbol lookup: return early on empty `symbols` #9435

Closed vlad-scherbich closed 4 months ago

vlad-scherbich commented 4 months ago

Summary: This change will avoid unnecessarily scanning all Elf sections when symbols to look-up are empty. In this case, getSymbolsByName will return early. Also added a test.

Reviewed By: nslingerland

Differential Revision: D53765727

facebook-github-bot commented 4 months ago

This pull request was exported from Phabricator. Differential Revision: D53765727

facebook-github-bot commented 4 months ago

This pull request was exported from Phabricator. Differential Revision: D53765727

facebook-github-bot commented 4 months ago

This pull request was exported from Phabricator. Differential Revision: D53765727

facebook-github-bot commented 4 months ago

This pull request was exported from Phabricator. Differential Revision: D53765727

facebook-github-bot commented 4 months ago

This pull request has been merged in facebook/hhvm@a5729bc8661bddac0129f9ab9c230a24767822c1.