Fix int64 handling sqlite3

facebook / hhvm

A virtual machine for executing programs written in Hack.

https://hhvm.com

Other

18.14k stars 2.99k forks source link

Fix int64 handling sqlite3 #9441

Closed jchaffraix-slack closed 5 months ago

jchaffraix-slack commented 5 months ago

The extension was using the sqlite3_*_int API, which would truncate 64-bits int to 32-bits on some code paths. The fix is to use the 64-bits API variants constantly throughout the extension.

Added a test that manipulates int64 that are not representable as int32 to make sure we handle those correctly.

facebook-github-bot commented 5 months ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 5 months ago

@ricklavoie merged this pull request in facebook/hhvm@c9c52eab33966eb991d8c7a063829277ca0227b5.