search

facebook / infer

A static analyzer for Java, C, C++, and Objective-C
http://fbinfer.com/
MIT License
14.97k stars 2.02k forks source link

[.NET resource leak checker] Traversing control flow through exception handler node #1623

Closed xi-liu-ds closed 2 years ago

xi-liu-ds commented 2 years ago

In this PR, we add support of traversing control flow through all exception handler nodes. This will significantly improve the precision of .NET resource leak checker.

jvillard commented 2 years ago

Apologies, we've had some conversations offline about this but I forgot the status of this PR. Are you still interested in getting this merged?

xi-liu-ds commented 2 years ago

Apologies, we've had some conversations offline about this but I forgot the status of this PR. Are you still interested in getting this merged?

Yes, we are still interested. Please feel free to give it a review and let us know your feedbacks. Thanks!

facebook-github-bot commented 2 years ago

@jvillard has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jvillard commented 2 years ago

Thanks @xi-liu-ds!

Just FYI I've made minor changes to simplify some of the boolean logic and ran make fmt before pushing.