facebook / infer

A static analyzer for Java, C, C++, and Objective-C
http://fbinfer.com/
MIT License
14.89k stars 2.01k forks source link

[java] fix missing dependency check in the Maven tests #1674

Closed jeremydubreil closed 1 year ago

jeremydubreil commented 2 years ago

The variable SOURCES was not defined, which means that changing the Java sources would not trigger the test if those had already been run before.

Without these changes, one could run:

$ make build_mvn_test

change the Java source file in a way that would change the list of Infer warnings, then, run again:

make build_mvn_test

and the test would still pass. This pull request fixes this.

All the tests are passing after the changes using make -j test.

facebook-github-bot commented 1 year ago

@jvillard has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jvillard commented 1 year ago

Thank you!