Closed jeremydubreil closed 1 year ago
@jvillard has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
Sounds good, the tests pass on the GitHub action. Can this PR get out of draft mode?
Thanks! The changes of this PR have been imported in https://github.com/facebook/infer/pull/1679 but I would rather have them merged independently so we should try to merge this one first.
@jeremydubreil has updated the pull request. You must reimport the pull request before landing.
@jvillard has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
I spoke too soon, the tests do not pass our internal CI, looks like we need to settle on Java 8 and not Java 11 for now.
@jeremydubreil has updated the pull request. You must reimport the pull request before landing.
@jvillard has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
The Java tests should not depend on the platforms they are run on. However, they depend on the version of the Java SDK used to compiled the test code.
This pull request set a fixed version of Java on both platforms.