[inferbo] add support for `insert` and `initializer_list` in `StdVector` model

facebook / infer

A static analyzer for Java, C, C++, and Objective-C

http://fbinfer.com/

MIT License

14.92k stars 2.01k forks source link

[inferbo] add support for `insert` and `initializer_list` in `StdVector` model #1831

Closed shenjunjiekoda closed 5 months ago

shenjunjiekoda commented 5 months ago

Introduction

This PR introduces supplements to the modeling of std::vector operations in InferBO Model, focusing particularly on the insert method and initializer_list related methods.

Details of Changes

Small Model Supplements: Added models in infer/src/bufferoverrun/bufferOverrunModels.ml for the std::vector::insert 3 overload methods including initializer_list is used as an argument , constructor for std::vector using initializer_list as an argument, constructor for initializer_list.
Testcase Supplements: Added testcase for supplements model in infer/tests/codetoanalyze/cpp/bufferoverrun/vector.cpp

Thank you for considering this update.

facebook-github-bot commented 5 months ago

@skcho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 5 months ago

@shenjunjiekoda has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 5 months ago

@skcho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

skcho commented 5 months ago

Hello, @shenjunjiekoda Thank you for the contribution! The initializer_list is one of the hardest parts to understand/handle, esp. when an implicit constructor is invoked in it. Anyhow, the PR looks good overall. I am surprised that you understood how Inferbo works and added new models. Amazing!

facebook-github-bot commented 5 months ago

@shenjunjiekoda has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 5 months ago

@shenjunjiekoda has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 5 months ago

@shenjunjiekoda has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 5 months ago

@shenjunjiekoda has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 5 months ago

@shenjunjiekoda has updated the pull request. You must reimport the pull request before landing.

shenjunjiekoda commented 5 months ago

Hello @skcho!

Thank you very much for the thorough review and valuable suggestions on my PR. As someone new to OCaml and Infer, I greatly appreciate your guidance and have learned a lot from it. I have made the necessary revisions based on your feedback and strive to continue improving my code.

Thanks again for your patience and support!

Best regards, shenjunjiekoda

facebook-github-bot commented 5 months ago

@skcho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 5 months ago

@shenjunjiekoda has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 5 months ago

@skcho merged this pull request in facebook/infer@d7efa0991dc8e25b14dec041d5a124e1ef069ecb.