facebook / jscodeshift

A JavaScript codemod toolkit.
https://jscodeshift.com
MIT License
9.11k stars 468 forks source link

Upgrade recast to 0.23.1 #544

Closed ryanrhee closed 1 year ago

ryanrhee commented 1 year ago

Typescript 4.9 added a new satisfies operator

Files written in ts4.9 fail jscodeshift as of now. recast needs to be upgraded so that ast-types is upgraded past v0.16.0 which is when support for TSatisfiesExpression was added.

facebook-github-bot commented 1 year ago

Hi @ryanrhee!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Daniel15 commented 1 year ago

@ryanrhee Please sign the CLA and I'll be able to merge this 😄

ryanrhee commented 1 year ago

@Daniel15 long time no see! :)

CLA is signed, just waiting for the bots to pick it up.

facebook-github-bot commented 1 year ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

ryanrhee commented 1 year ago

CLA signed, lockfile updated, & confirmed that yarn test passes.

Daniel15 commented 1 year ago

@Daniel15 long time no see! :)

Yeah, it's been a while :) Thanks for the PR.

aaronccasanova commented 1 year ago

Hey @Daniel15 👋 Do you have an estimate on when this upgrade will be released?

Daniel15 commented 1 year ago

Sorry for the delay @aaronccasanova. I'll push out an update this week.