search

facebook / jsx

The JSX specification is a XML-like syntax extension to ECMAScript.
http://facebook.github.io/jsx/
1.95k stars 133 forks source link

Editorial: add a few missing type="definition" #150

Closed Josh-Cena closed 1 year ago

Josh-Cena commented 1 year ago

There are a few nonterminals that are not linkable, e.g. JSXString (try https://facebook.github.io/jsx/#prod-JSXString on the current deployment). This is due to the missing type="definition" attr.

(I've built the index.html myself. Let me know if I need to revert that.)

Jack-Works commented 1 year ago

There is a GitHub action that can automatically re-build the spec, but I don't know if Facebook accepts that.

Maybe we should cc the maintainer of this spec cc Huxpro 👀

See: https://github.com/tc39/template-for-proposals/blob/main/.github/workflows/build.yml

Josh-Cena commented 1 year ago

Err... I assume it's already there?

Jack-Works commented 1 year ago

Oh! Yes, I can see it in the commit history 😂

image

Josh-Cena commented 1 year ago

OK, I've reverted the index.html changes in that case. If Xuan wants to review the build output he can still review the diff of https://github.com/facebook/jsx/pull/150/commits/e36a25592df4318d8f054cd78e56dbd1cdcd91db ^^

Josh-Cena commented 1 year ago

Minor ping for @Huxpro in case this fell off your radar 👀

Huxpro commented 1 year ago

Minor ping for @Huxpro in case this fell off your radar 👀

Oops I definitely missed this completely. Thanks for the ping and fixes!