facebook / jsx

The JSX specification is a XML-like syntax extension to ECMAScript.
http://facebook.github.io/jsx/
1.96k stars 133 forks source link

invalid type of attribute value #32

Closed fxbois closed 8 years ago

fxbois commented 9 years ago

after discussion with @vjeux

vjeux commented 9 years ago

cc @syranide @sebmarkbage

syranide commented 9 years ago

+1 Yep that should be correct.

sebmarkbage commented 9 years ago

Actually that's not current. We explicitly decided to allow this in the syntax but never implemented it in React transpiler. We should be parsing it correctly though:

https://github.com/facebook/esprima/blob/fb-harmony/esprima.js#L7000

RReverser commented 9 years ago

Yeah, this is parsed correctly and supported for transpiling in Babel. If we want to remove it, I believe we need some separate issue for discussion prior to the PR.