search

facebook / ktfmt

A program that reformats Kotlin source code to comply with the common community standard for Kotlin code conventions.
https://facebook.github.io/ktfmt/
Apache License 2.0
907 stars 75 forks source link

Remove duplicated line in editorconfig for dropbox style #456

Closed sabufung30 closed 5 months ago

sabufung30 commented 5 months ago

Remove ij_java_names_count_to_use_import_on_demand = 9999 in .editorconfig-dropbox

facebook-github-bot commented 5 months ago

Hi @sabufung30!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 5 months ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot commented 5 months ago

@hick209 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

hick209 commented 5 months ago

@sabufung30 thank you so much for the contribution!

Before we move forward, could you please add more context on why this change is required?

sabufung30 commented 5 months ago

@sabufung30 thank you so much for the contribution!

Before we move forward, could you please add more context on why this change is required?

There will be warning because of the duplicated config from IDE. Line 15 and 66 are identical

hick209 commented 5 months ago

Oof, sorry I missed that. Thanks for the fix 😃

facebook-github-bot commented 5 months ago

@hick209 merged this pull request in facebook/ktfmt@32bdde511367a51573c3d172e23dd59b6cb6d09e.