search

facebook / ktfmt

A program that reformats Kotlin source code to comply with the common community standard for Kotlin code conventions.
https://facebook.github.io/ktfmt/
Apache License 2.0
857 stars 66 forks source link

Further refactoring on CLI #476

Closed grodin closed 3 weeks ago

grodin commented 3 weeks ago

This doesn't add any features or fix any bugs, but does change the style option from --dropbox-style to --style=dropbox (and similarly for the other styles) as discussed in #391.

grodin commented 3 weeks ago

I've got a follow on PR ready to go which adds --help. I can happily push it into this branch but I thought I'd keep it separate to start with.

hick209 commented 3 weeks ago

As this one breaks the current CLI API contract, let's land it last as make it part of the 1.0.0 release.

Do you think we could land the --help one before this here?

grodin commented 3 weeks ago

I've reverted the commit that adds --style= since the other stuff is just refactoring, and I'm quite keen to land that refactoring before I do too much more. I'll follow up immediately with --help and move --style= to a separate PR

hick209 commented 3 weeks ago

SGTM 😃

facebook-github-bot commented 3 weeks ago

@hick209 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.