search

facebook / lexical-ios

Lexical iOS is an extensible text editor framework that integrates the APIs and philosophies from Lexical Web with a Swift API built on top of TextKit.
MIT License
549 stars 41 forks source link

Add button to create Numbered List in Playground (Issue #7) #19

Closed patelneal closed 1 year ago

patelneal commented 1 year ago

Summary: Add button to create Numbered List in Playground as part of Issue #7

Numbered List Button

Screenshot 2023-04-06 at 1 40 30 PM

Numbered List

Screenshot 2023-04-06 at 1 41 58 PM
facebook-github-bot commented 1 year ago

@amyworrall has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

amyworrall commented 1 year ago

Do numbered lists work ok if you indent one of the list items to form a child list? (Use the indent buttons on the toolbar of the playground)

patelneal commented 1 year ago

Do numbered lists work ok if you indent one of the list items to form a child list? (Use the indent buttons on the toolbar of the playground)

This is what I am seeing when I use the indent buttons

Screenshot 2023-04-06 at 2 46 59 PM
patelneal commented 1 year ago

Do numbered lists work ok if you indent one of the list items to form a child list? (Use the indent buttons on the toolbar of the playground)

Lists do however seem to increment the count for sublists like below

Screenshot 2023-04-06 at 3 08 50 PM
facebook-github-bot commented 1 year ago

@amyworrall merged this pull request in facebook/lexical-ios@d2bfdefed06d6cad72ad330ecb67d7c69a8c01e2.