search

facebook / lexical-ios

Lexical iOS is an extensible text editor framework that integrates the APIs and philosophies from Lexical Web with a Swift API built on top of TextKit.
MIT License
538 stars 38 forks source link

LexicalViewDelegate's textViewShouldChangeText updated to return Bool #31

Closed gregzo closed 1 year ago

gregzo commented 1 year ago

The current implementation does not allow the LexicalView's delegate to refuse text changes in textViewShouldChangeText. This PR remediates that by updating the return type of the LexicalViewDelegate protocol from Void to Bool and making the necessary changes in the LexicalView extension which implements LexicalViewDelegate.

Tests have been run successfully.

facebook-github-bot commented 1 year ago

@amyworrall has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@amyworrall has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@amyworrall merged this pull request in facebook/lexical-ios@ebadf6a0c19d97ba8a122b6ddd03cf18fac6e581.