facebook / lexical-ios

Lexical iOS is an extensible text editor framework that integrates the APIs and philosophies from Lexical Web with a Swift API built on top of TextKit.
MIT License
549 stars 41 forks source link

Fix nested numbered lists item numbering #38

Closed damirstuhec closed 1 year ago

damirstuhec commented 1 year ago

Since nested lists are wrapped inside their own ListItemNodes, they got counted towards "previous siblings" when generating a list item number character, resulting in an inaccurate number.

This PR fixes that by not counting sibling items containing nested lists towards the "previous siblings" count.

facebook-github-bot commented 1 year ago

Hi @damirstuhec!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 1 year ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot commented 1 year ago

@amyworrall has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@amyworrall merged this pull request in facebook/lexical-ios@eb600a02e5c858fed3f6a9baa81c7734f057ca30.