search

facebook / lexical

Lexical is an extensible text editor framework that provides excellent reliability, accessibility and performance.
https://lexical.dev
MIT License
17.5k stars 1.45k forks source link

Fix: dropdown misplacement after scrolling #5290

Closed paigekim29 closed 2 weeks ago

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2024 1:51pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2024 1:51pm
ivailop7 commented 5 months ago

Could we get a before and after on this and some description please, I'm unable to reproduce what the issue is.

ivailop7 commented 4 months ago

Actually, ignore my approval of this one. Trying this in the Preview Link, it makes things worse than they are right now. if have long text and have scrolled down and then open a dropdown, the dropdown is rendered with scroll offset in the middle of the screen vs at the end of the toolbar height. This PR doesn't seem to be fixing anything. Could you provide an example the issue this PR is meant to be fixing?

paigekim29 commented 4 months ago

@ivailop7 I have created a new PR https://github.com/facebook/lexical/pull/5443. I believe that position:fixed is causing an issue after scrolling.

ivailop7 commented 4 months ago

@ivailop7 I have created a new PR #5443. I believe that position:fixed is causing an issue after scrolling.

why the separate PR, instead of updating this one?

paigekim29 commented 4 months ago

@ivailop7 I updated it as you recommended, so please check the video for the changes

Before

After

zurfyx commented 4 months ago

Can we please look into the failing tests and/or rebase?

paigekim29 commented 2 weeks ago

will look into it and request after fix