search

facebook / lexical

Lexical is an extensible text editor framework that provides excellent reliability, accessibility and performance.
https://lexical.dev
MIT License
17.5k stars 1.45k forks source link

fixed:#5646 Bug: Header becomes a numbered list #5705

Open muskan2622 opened 2 months ago

muskan2622 commented 2 months ago

Lexical version: 0.13.1

Steps To Reproduce Go to the Lexical Playground Modify the Welcome to the playground header and make it 1. Welcome to the playground Notice it converts to a numbered list item instead of remaining a header as soon as you make a space between 1. and Welcome image

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 11:15am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 11:15am
facebook-github-bot commented 2 months ago

Hi @muskan2622!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

ivailop7 commented 2 months ago

Hi, Is this meant to be a draft PR? I'm not seeing an actual fix for the referenced mention in the title.

facebook-github-bot commented 2 months ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

muskan2622 commented 2 months ago

@ivailop7 I have added condition such that If we add any number with . It should remain header itself

ivailop7 commented 2 months ago

But this is just a change to the test file, not addressing the actual issue, which is keeping the Heading format inside the bullet item.