Closed potatowagon closed 2 weeks ago
vercel[bot]
commented
1 month ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| lexical | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 29, 2024 1:58am |
| lexical-playground | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 29, 2024 1:58am |
github-actions[bot]
commented
1 month ago | Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
|---|---|---|---|---|
| packages/lexical/dist/Lexical.js | 23.66 KB (0%) | 474 ms (0%) | 338 ms (+11.56% 🔺) | 811 ms |
| packages/lexical-rich-text/dist/LexicalRichText.js | 33.88 KB (0%) | 678 ms (0%) | 873 ms (-9.23% 🔽) | 1.6 s |
| packages/lexical-plain-text/dist/LexicalPlainText.js | 33.86 KB (0%) | 678 ms (0%) | 1.1 s (+15.16% 🔺) | 1.8 s |
StyleT
commented
1 month ago Hi!
Let's add selection of the affected modules to the PR template, so we can sort them easier. Ex: [package name] (@lexical/core). This would allow people that recently worked on the respective packages to review PRs faster.
Also sorting by type would help: chore, docs, feat, bug...
potatowagon
commented
1 month ago Let's add selection of the affected modules to the PR template, so we can sort them easier. Ex: [package name] (@lexical/core). Also sorting by type would help: chore, docs, feat, bug...
do u have an example of how this would fit into the PR template? youre welcomed to suggest a code change directly onto .github/pull_request_template.md
https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository