Closed etrepum closed 6 days ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
lexical | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 24, 2024 10:51pm |
lexical-playground | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 24, 2024 10:51pm |
@StyleT I wanted to put this up earlier on in case you had any feedback on this approach. Probably just look at the last commit, the rest of them are from the other PRs.
@StyleT
happy to rebase and fix conflicts on this one when someone gives me a heads-up (on here or discord) that they're ready to review and consider for merge, I don't want to have to do it too many times (edit: merged with main on 2024-04-17 to sync up with v0.14.5)
This looks good to me - huge improvement.
I honestly don't know if all the WWW and flow stuff is right, but I think the fastest way to tell is to merge and fix any issues that come up in the sync.
I'll run a sync internally ASAP, then we can merge this and do a sync with just this PR so we can catch any issues.
Addresses refactoring of npm/build processes per #5869
README.md
anddocs/packages/{package}.md
files (npm run update-docs)RE #5869 this mostly addresses the "Reduce number of changes needed to add new package" - since I have not added a new package myself yet I think another maintainer (@StyleT?) could add those docs to the guide using this as a baseline?
I was also thinking about maybe starting on an eslint plugin in the next week or two to help with the "rules of $functions" so if someone else doesn't get to it first I could add that documentation then when I am more familiar with all of those details.
Closes #5940 (parts of this PR were extracted there to maybe expedite review)