facebook / lexical

Lexical is an extensible text editor framework that provides excellent reliability, accessibility and performance.
https://lexical.dev
MIT License
17.37k stars 1.43k forks source link

Add $ prefix to updateToolbar on react-rich example #5887

Closed 2wheeh closed 2 weeks ago

2wheeh commented 2 weeks ago

Should this be with $ prefix ?

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2024 9:19pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2024 9:19pm
potatowagon commented 2 weeks ago

related discussion about $ prefix: https://github.com/facebook/lexical/discussions/1800#discussioncomment-2585547

2wheeh commented 2 weeks ago

@potatowagon hi, looks like your last comment might have landed on the wrong PR 😋

potatowagon commented 2 weeks ago

@potatowagon hi, looks like your last comment might have landed on the wrong PR 😋

haha oh dear silly me thanks for letting me know! 😅