search

facebook / lexical

Lexical is an extensible text editor framework that provides excellent reliability, accessibility and performance.
https://lexical.dev
MIT License
17.37k stars 1.43k forks source link

Remove a special case in table deleteTextHandler #5891

Closed AlexanderReznik closed 2 weeks ago

AlexanderReznik commented 2 weeks ago

This was introduced in https://github.com/facebook/lexical/pull/3213 but wasn't cleaned up after a proper fix. Currently this does not allow the removal of empty lines in a collapsible section inside of a table.

Before: table-collapsible-paragraph

After: table-collapsible-paragraph-after

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 9:39am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 9:39am
StyleT commented 2 weeks ago

Hi! Thanks for this fix! Do you think we can write a test for it?

AlexanderReznik commented 2 weeks ago

Hi! Thanks for this fix! Do you think we can write a test for it?

Sure! https://github.com/facebook/lexical/pull/5891/commits/d95d99f6bed4a8d60775400b712bb96c01d49891