Closed acywatson closed 3 weeks ago
vercel[bot]
commented
3 weeks ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| lexical | ✅ Ready (Inspect) | Visit Preview | Apr 24, 2024 2:08pm | |
| lexical-playground | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 24, 2024 2:08pm |
github-actions[bot]
commented
3 weeks ago | Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
|---|---|---|---|---|
| packages/lexical/dist/Lexical.js | 23.64 KB (0%) | 473 ms (0%) | 81 ms (+23.21% 🔺) | 554 ms |
| packages/lexical-rich-text/dist/LexicalRichText.js | 33.83 KB (0%) | 677 ms (0%) | 251 ms (+28.3% 🔺) | 928 ms |
| packages/lexical-plain-text/dist/LexicalPlainText.js | 33.76 KB (0%) | 676 ms (0%) | 400 ms (+53.99% 🔺) | 1.1 s |
acywatson
commented
3 weeks ago Actually, maybe there is a reason to do this - we want to run the checks on the tip of main (though I struggle to think of a time when this has ever been practically useful).
What we actually need to do here is prevent cancelling on push, so the checks actually aren't cancelled by subsequent merges. Especially since we tend to merge in spurts.
We run the tests on PR, then again on merge. There's no reason to do that, really and it almost always gets cancelled by something else getting merged right after.