search

facebook / lexical

Lexical is an extensible text editor framework that provides excellent reliability, accessibility and performance.
https://lexical.dev
MIT License
17.5k stars 1.45k forks source link

Refactor table resizer rendering logic #5957

Closed AlexanderReznik closed 3 weeks ago

AlexanderReznik commented 3 weeks ago

Disabling table resizer when mouse button is pressed, instead of when the selection is of type TableSelection.

This makes ui slightly better in some cases:

  1. Cursor doesn't change when starting the table selection table-selection-cursor

  2. Cursor doesn't change when during range selection the cursor is over the table range-selection-cursor

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 4:50pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 4:50pm
ivailop7 commented 3 weeks ago

@AlexanderReznik, in the preview here, I'm still getting the selection stuck

AlexanderReznik commented 3 weeks ago

@AlexanderReznik, in the preview here, I'm still getting the selection stuck

This is not getting fixed in this pr, but I'll try to fix it later

ivailop7 commented 3 weeks ago

@AlexanderReznik, in the preview here, I'm still getting the selection stuck

This is not getting fixed in this pr, but I'll try to fix it later

Ah, misunderstood what this was fixing. My fault. All good now. Thanks, Alex!