facebook / lexical

Lexical is an extensible text editor framework that provides excellent reliability, accessibility and performance.
https://lexical.dev
MIT License
17.5k stars 1.45k forks source link

Fixed the issue of playground crashing when the selected node contain… #5960

Closed i-tengfei closed 2 weeks ago

i-tengfei commented 3 weeks ago

When the selected node contains HeadingNode or QuoteNode, the selected node will be replaced by ParagraphNode, and execution of selection.extract will crash.

Fix: https://github.com/facebook/lexical/pull/5849#issuecomment-2076631398

https://github.com/facebook/lexical/assets/1763168/feba027b-39a7-4eba-b41b-ce3dd1b531e0

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 8:59am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 8:59am
facebook-github-bot commented 3 weeks ago

Hi @i-tengfei!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 3 weeks ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!