Fix #5738 wrong selection on mouse click

facebook / lexical

Lexical is an extensible text editor framework that provides excellent reliability, accessibility and performance.

https://lexical.dev

MIT License

17.5k stars 1.45k forks source link

Closed Sahejkm closed 2 weeks ago

Sahejkm commented 2 weeks ago

The Crash looks partially resolved before this fix - it doesn't crash anymore.
But the wrong selection leads to wrong behaviour on backspace command and doesn't delete hr correctly if we try delete from the wrong selection state

Fix: Fix the wrong selection Resolved state due to Block Cursor element

closes #5738

Before ( delete command doesn't delete hr element)

After ( delete command deletes hr element correctly )

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 29, 2024 4:44am
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 29, 2024 4:44am

github-actions[bot] commented 2 weeks ago

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
packages/lexical/dist/Lexical.js	23.69 KB (+0.11% 🔺)	474 ms (+0.11% 🔺)	182 ms (+271.11% 🔺)	656 ms
packages/lexical-rich-text/dist/LexicalRichText.js	33.91 KB (+0.11% 🔺)	679 ms (+0.11% 🔺)	162 ms (-13.12% 🔽)	840 ms
packages/lexical-plain-text/dist/LexicalPlainText.js	33.91 KB (+0.16% 🔺)	679 ms (+0.16% 🔺)	184 ms (+10.39% 🔺)	863 ms

zurfyx commented 2 weeks ago

LGTM! You may want to update the description and add some test if possible

Sahejkm commented 2 weeks ago

Lemme add the tests in a separate PR since this is already approved.