Fix: #5974 Cursor jump to the end of the document when a collaborator deletes focusing paragraph

facebook / lexical

Lexical is an extensible text editor framework that provides excellent reliability, accessibility and performance.

https://lexical.dev

MIT License

17.5k stars 1.45k forks source link

Open matsuyama-k1 opened 2 weeks ago

matsuyama-k1 commented 2 weeks ago

fixed #5974

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 15, 2024 10:51am
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 15, 2024 10:51am

ivailop7 commented 2 weeks ago

@fantactuka could you look into this one, would really like to land this one before the next release.

StyleT commented 2 weeks ago

This is great! Can you pls add a test for this fix? To prevent regression

matsuyama-k1 commented 1 week ago

I added a test and fixed! It looks like integrity test is failed because Collaboration.test.ts is not completely typed.

matsuyama-k1 commented 1 day ago

The pull request that almost same with my code was created and passed....😢 It was any mention for my PR or issue despite mentioning other issues.

is it ok in Lexilcal community?